Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pipelines #1445

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Fix CI pipelines #1445

merged 11 commits into from
Jan 15, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 15, 2025

@m7pr m7pr added the core label Jan 15, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Jan 15, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 15, 2025

Started a new job after recent changes https://github.com/insightsengineering/teal/actions/runs/12784947499

@m7pr
Copy link
Contributor Author

m7pr commented Jan 15, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 15, 2025

@pawelru an interesting case for you.
teal depends on MultiAssayExperiment in Suggests, but during min_isolated build
https://github.com/insightsengineering/teal/actions/runs/12784947499/job/35639440420#step:9:710 you can see that it tries to load very old version of SummarizedExperiment which is a dependency of MultiAssayExperiment. This old version depends on old MatrixGenerics that depends on matrixStats that can not be installed.

However, newest version of SummarizedExperiment depends on newer MatrixGenerics that doesn't have installation issues and all the build is satisfied https://github.com/insightsengineering/teal/actions/runs/12785524755 but I needed to add SummarizedExperiment experiment to package Suggests just to satisfy the build, even though this package is not directly needed for teal.

Do you have any advice on how we should proceed? Let the min_isolated fail, allow SummarizedExperiment to be added to Suggests, or to some Enhances or Linking to fields?

@pawelru
Copy link
Contributor

pawelru commented Jan 15, 2025

Please have a look at the extra-deps workflow parameter. It was designed to handle such cases and allow to provide specification of indirect dependencies not to pollute DESCIRPTION file as you mentioned

@m7pr
Copy link
Contributor Author

m7pr commented Jan 15, 2025

Amazing, thanks for the hint :)!

@m7pr
Copy link
Contributor Author

m7pr commented Jan 15, 2025

@m7pr m7pr marked this pull request as ready for review January 15, 2025 13:55
@m7pr m7pr requested a review from llrs-roche January 15, 2025 13:55
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra-deps fixed the min_isolate check: before vs after.
The other dependencies fixed the rest.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Unit Tests Summary

  1 files   27 suites   10m 22s ⏱️
276 tests 272 ✅ 4 💤 0 ❌
537 runs  533 ✅ 4 💤 0 ❌

Results for commit 7702273.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $150.20$ $-2.21$ $0$ $0$ $0$ $0$

Results for commit fe3755b

♻️ This comment has been updated with latest results.

@m7pr m7pr enabled auto-merge (squash) January 15, 2025 15:05
@m7pr m7pr merged commit 9b6ddd0 into main Jan 15, 2025
28 checks passed
@m7pr m7pr deleted the fix_scheduled branch January 15, 2025 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants