Skip to content

251 deleayed datasets@main #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Feb 6, 2025

Closes #251

Added function delayed_datasets. Use it to specify dataname in data_extract_spec to obtain a delayed_data_dextract_spec that will be turned into a number of ddes after confronting actual data.

Moved entire UI logic of data_extract_module to a renderUI call in the server function. Arguments label and is_single_data_extract are passed to the server function by creating invisible inputs and putting the argument values into them. The argument data_extract_spec is now unused. The same des is passed to the server function so all operations on it can be done in the server function without issue.
The argument data_extract_spec could now be removed from the ui function but that would require changes in all modules so I left it in.

Addded function assert_delayed_datasets that checks that delayed_datasets are used properly when building data_extract_specs.

@chlebowa chlebowa force-pushed the 251_deleayed_datasets@main branch from 663eb4c to 0fa6430 Compare February 12, 2025 08:34
@chlebowa chlebowa force-pushed the 251_deleayed_datasets@main branch from 0fa6430 to 6616eab Compare February 12, 2025 13:42
@chlebowa chlebowa marked this pull request as ready for review February 12, 2025 16:18
@gogonzo
Copy link
Contributor

gogonzo commented Feb 20, 2025

@chlebowa please close this PR. We will take care of the #255

@chlebowa chlebowa closed this Feb 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Introduce a delayed_datasets functionality
2 participants