Skip to content

Commit

Permalink
Adds min package version (#405)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #332

### 🔴 Checklist for PR Reviewer

[![Scheduled
🕰️](https://github.com/insightsengineering/teal.slice/actions/workflows/scheduled.yaml/badge.svg?branch=verdepcheck_action)](https://github.com/insightsengineering/teal.slice/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action)
_(see comment below)_

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [ ] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [ ] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Sep 21, 2023
1 parent d95ee85 commit 0d1308f
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
43 changes: 32 additions & 11 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -29,37 +29,58 @@ URL: https://insightsengineering.github.io/teal.slice/,
BugReports: https://github.com/insightsengineering/teal.slice/issues
Depends:
R (>= 4.0),
shiny
shiny (>= 1.6.0)
Imports:
bslib (>= 0.4.0),
checkmate,
dplyr,
checkmate (>= 2.1.0),
dplyr (>= 1.0.5),
grDevices,
htmltools,
htmltools (>= 0.5.4),
jsonlite,
lifecycle,
lifecycle (>= 0.2.0),
logger (>= 0.2.0),
methods,
plotly,
R6,
shinycssloaders,
plotly (>= 4.9.2.2),
R6 (>= 2.2.0),
shinycssloaders (>= 1.0.0),
shinyjs,
shinyWidgets (>= 0.6.2),
teal.data (>= 0.3.0),
teal.logger (>= 0.1.1),
teal.widgets (>= 0.4.0)
Suggests:
knitr,
knitr (>= 1.42),
MultiAssayExperiment,
rmarkdown,
SummarizedExperiment,
testthat (>= 3.1.5),
utils,
withr
withr (>= 2.1.0)
VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/verdepcheck:
rstudio/shiny,
rstudio/bslib,
mllg/checkmate,
tidyverse/dplyr,
rstudio/htmltools,
jeroen/jsonlite,
r-lib/lifecycle,
daroczig/logger,
plotly/plotly,
r-lib/R6,
daattali/shinycssloaders,
daattali/shinyjs,
dreamRs/shinyWidgets,
insightsengineering/teal.data,
insightsengineering/teal.logger,
insightsengineering/teal.widgets,
yihui/knitr,
MultiAssayExperiment=bioc::MultiAssayExperiment,
SummarizedExperiment=bioc::SummarizedExperiment,
r-lib/testthat,
r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# teal.slice 0.4.0.9013

### Miscellaneous

* Specified minimal version of package dependencies.

# teal.slice 0.4.0

### New features
Expand Down

0 comments on commit 0d1308f

Please sign in to comment.