Skip to content

Commit

Permalink
Adds min package version (#194)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #189

### 🔴 Checklist for PR Reviewer

- [x] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Sep 5, 2023
1 parent 8fdc34a commit 51a677a
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
45 changes: 32 additions & 13 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,48 @@ URL: https://github.com/insightsengineering/teal.reporter,
BugReports: https://github.com/insightsengineering/teal.reporter/issues
Imports:
bslib,
checkmate,
checkmate (>= 2.1.0),
grid,
htmltools,
knitr,
lifecycle,
htmltools (>= 0.5.4),
knitr (>= 1.34),
lifecycle (>= 0.2.0),
R6,
rmarkdown,
shiny,
shinyWidgets,
yaml,
zip
rmarkdown (>= 2.19),
shiny (>= 1.6.0),
shinyWidgets (>= 0.5.1),
yaml (>= 1.1.0),
zip (>= 1.1.0)
Suggests:
DT,
ggplot2,
lattice,
DT (>= 0.13),
ggplot2 (>= 3.4.0),
lattice (>= 0.18-4),
png,
rtables (>= 0.5.1),
testthat,
testthat (>= 3.0.4),
tinytex
VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/verdepcheck:
rstudio/bslib,
mllg/checkmate,
rstudio/htmltools,
yihui/knitr,
r-lib/lifecycle,
r-lib/R6,
rstudio/rmarkdown,
rstudio/shiny,
dreamRs/shinyWidgets,
yaml=vubiostat/r-yaml,
r-lib/zip,
rstudio/DT,
tidyverse/ggplot2,
deepayan/lattice,
cran/png,
insightsengineering/rtables,
r-lib/testthat,
rstudio/tinytex
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# teal.reporter 0.2.0.9002

### Miscellaneous

* Specify minimal version of dependent packages.

# teal.reporter 0.2.0

### New features
Expand Down

0 comments on commit 51a677a

Please sign in to comment.