Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgdown redirect #253

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix pkgdown redirect #253

merged 2 commits into from
Feb 9, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Feb 8, 2024

@vedhav vedhav added bug Something isn't working core labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             252     252  0.00%    83-368
R/tm_g_ae_sub.R               315     315  0.00%    59-410
R/tm_g_butterfly.R            388     388  0.00%    124-552
R/tm_g_decorate.R              46      46  0.00%    18-98
R/tm_g_events_term_id.R       299     299  0.00%    63-400
R/tm_g_heat_bygrade.R         321     321  0.00%    135-492
R/tm_g_patient_profile.R      711     711  0.00%    159-935
R/tm_g_spiderplot.R           324     324  0.00%    99-468
R/tm_g_swimlane.R             378     378  0.00%    125-560
R/tm_g_waterfall.R            427     427  0.00%    108-586
R/utils.R                      37      32  13.51%   32-91, 124-131
R/zzz.R                         1       1  0.00%    2
TOTAL                        3499    3494  0.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ff24d20

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit ff24d20.

♻️ This comment has been updated with latest results.

@vedhav vedhav enabled auto-merge (squash) February 8, 2024 17:56
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedhav you sure you wanted to update so many .Rd files?

@vedhav
Copy link
Contributor Author

vedhav commented Feb 9, 2024

Let me check this. This is weird. There is no change to roxygen2 version here so there should not be this many .Rd changes.

@m7pr
Copy link
Contributor

m7pr commented Feb 9, 2024

It's a change reflecting the @rdname tag change (from ?teal::module into ?teal::_teal_module) from here insightsengineering/teal#1074 done in here insightsengineering/teal#1087

@vedhav
Copy link
Contributor Author

vedhav commented Feb 9, 2024

Got it, Then it looks alright to me. There was just a warning from using the older @docType package syntax so I updated it.

@vedhav vedhav requested a review from m7pr February 9, 2024 12:32
@vedhav vedhav merged commit ad37174 into main Feb 9, 2024
24 checks passed
@vedhav vedhav deleted the 506-fix-pkgdown-redirect branch February 9, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants