Skip to content

Commit

Permalink
Adds min package version (#222)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #206

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [ ] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Signed-off-by: Pawel Rucki <[email protected]>
Co-authored-by: Pawel Rucki <[email protected]>
  • Loading branch information
averissimo and pawelru authored Apr 8, 2024
1 parent c048374 commit 375c92b
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
40 changes: 32 additions & 8 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -23,30 +23,54 @@ BugReports: https://github.com/insightsengineering/teal.osprey/issues
Depends:
osprey (>= 0.1.16),
R (>= 3.6),
shiny,
shiny (>= 1.6.0),
teal (>= 0.14.0.9027),
teal.transform (>= 0.4.0.9011)
Imports:
checkmate,
dplyr,
checkmate (>= 2.1.0),
dplyr (>= 1.0.5),
formatters (>= 0.3.1),
ggplot2,
lifecycle,
ggplot2 (>= 3.4.0),
lifecycle (>= 0.2.0),
shinyvalidate,
teal.code (>= 0.4.1.9009),
teal.logger (>= 0.1.3.9013),
teal.reporter (>= 0.2.0),
teal.widgets (>= 0.4.0),
tern (>= 0.7.10),
tidyr
tidyr (>= 0.8.3)
Suggests:
knitr,
knitr (>= 1.42),
logger (>= 0.2.0),
nestcolor (>= 0.1.0),
rmarkdown,
rmarkdown (>= 2.19),
teal.data (>= 0.3.0.9018),
testthat (>= 3.1.5),
withr (>= 2.0.0)
Config/Needs/verdepcheck:
insightsengineering/osprey,
rstudio/shiny,
insightsengineering/teal,
insightsengineering/teal.transform,
mllg/checkmate,
tidyverse/dplyr,
insightsengineering/formatters,
tidyverse/ggplot2,
r-lib/lifecycle,
rstudio/shinyvalidate,
insightsengineering/teal.code,
insightsengineering/teal.logger,
insightsengineering/teal.reporter,
insightsengineering/teal.widgets,
insightsengineering/tern,
tidyverse/tidyr,
yihui/knitr,
daroczig/logger,
insightsengineering/nestcolor,
rstudio/rmarkdown,
insightsengineering/teal.data,
r-lib/testthat,
r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
### Breaking Changes
* Adapted all modules to use `teal_data` objects.

### Miscellaneous

* Specified minimal version of package dependencies.

# teal.osprey 0.1.16

* Removed `scda` package dependency from examples.
Expand Down

0 comments on commit 375c92b

Please sign in to comment.