Skip to content

Commit

Permalink
Adds min package version (#538)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #527

### 🔴 Checklist for PR Reviewer

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Sep 14, 2023
1 parent 1fb3f98 commit f4e15d0
Show file tree
Hide file tree
Showing 3 changed files with 65 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
76 changes: 60 additions & 16 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -17,38 +17,38 @@ Description: General Purpose Teal Modules.
License: Apache License 2.0 | file LICENSE
Depends:
ggmosaic (>= 0.3.0),
ggplot2,
ggplot2 (>= 3.4.0),
R (>= 3.6),
shiny,
shiny (>= 1.6.0),
shinyTree,
teal (>= 0.14.0)
Imports:
checkmate,
dplyr,
DT,
checkmate (>= 2.1.0),
dplyr (>= 1.0.5),
DT (>= 0.13),
forcats (>= 1.0.0),
grid,
logger (>= 0.2.0),
magrittr,
magrittr (>= 1.5),
scales,
shinyjs,
shinyvalidate,
shinyWidgets,
shinyWidgets (>= 0.5.1),
stats,
stringr,
stringr (>= 1.4.1),
teal.code (>= 0.4.0),
teal.logger (>= 0.1.1),
teal.reporter (>= 0.2.0),
teal.slice (>= 0.4.0),
teal.transform (>= 0.4.0),
teal.widgets (>= 0.4.0),
tern (>= 0.7.10),
tibble,
tidyr,
tibble (>= 2.0.0),
tidyr (>= 0.8.3),
tidyselect,
utils
Suggests:
broom,
broom (>= 0.7.10),
colourpicker,
ggExtra,
ggpmisc (>= 0.4.3),
Expand All @@ -57,19 +57,63 @@ Suggests:
gridExtra,
htmlwidgets,
jsonlite,
knitr,
lattice,
knitr (>= 1.42),
lattice (>= 0.18-4),
MASS,
methods,
nestcolor (>= 0.1.0),
rlang,
rmarkdown,
rlang (>= 1.0.0),
rtables (>= 0.5.1),
sparkline,
teal.data (>= 0.3.0),
testthat (>= 2.0)
testthat (>= 3.0.4)
VignetteBuilder:
knitr
Config/Needs/verdepcheck:
haleyjeppson/ggmosaic,
tidyverse/ggplot2,
rstudio/shiny,
shinyTree/shinyTree,
insightsengineering/teal,
mllg/checkmate,
tidyverse/dplyr,
rstudio/DT,
tidyverse/forcats,
daroczig/logger,
tidyverse/magrittr,
r-lib/scales,
daattali/shinyjs,
rstudio/shinyvalidate,
dreamRs/shinyWidgets,
tidyverse/stringr,
insightsengineering/teal.code,
insightsengineering/teal.logger,
insightsengineering/teal.reporter,
insightsengineering/teal.slice,
insightsengineering/teal.transform,
insightsengineering/teal.widgets,
insightsengineering/tern,
tidyverse/tibble,
tidyverse/tidyr,
r-lib/tidyselect,
tidymodels/broom,
daattali/colourpicker,
daattali/ggExtra,
aphalo/ggpmisc,
aphalo/ggpp,
baddstats/goftest,
gridExtra,
ramnathv/htmlwidgets,
jeroen/jsonlite,
yihui/knitr,
deepayan/lattice,
MASS,
insightsengineering/nestcolor,
r-lib/rlang,
insightsengineering/rtables,
sparkline,
insightsengineering/teal.data,
r-lib/testthat
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# teal.modules.general 0.2.16.9007

### Miscellaneous

* Specified minimal version of package dependencies.

# teal.modules.general 0.2.16

### Breaking changes
Expand Down

0 comments on commit f4e15d0

Please sign in to comment.