Adds names() function and deprecates datanames()

[averissimo]

Pull Request

• Fixes [Feature Request]: Don't use @datanames anymore #333
• Companion of Adds names(qenv/qenv.error) S3 methods teal.code#218

Blockers

• {teal.code}
  • Merge Adds names(qenv/qenv.error) S3 methods teal.code#218

Changes description

• Adds names() function
  • Setter is implemented but throws warning (does nothing)
• Deprecates datanames() getter and setter
• Adapt tests to new API
• Update NEWS
• Review documentation
• Review vignettes

[gogonzo]

I acknowledge introducing names<- just to deprecate itself

[averissimo]

Using names in body which will return all objects, including with dot prefix.

I don't think it makes sense to use ls(x, all.names = FALSE) as that changes the way the function works.

We could add support to ls via some trickery, but I'm leaning against it, mainly as it will appear as masking ls when loading the package.

#' @export
ls <- function(x, ...) {
  UseMethod("ls")
}

#' @export
ls.teal_data <- function(x, ...) {
  names_x <- base::ls(as.environment(x), ...)
  .get_sorted_names(names_x, join_keys(x), as.environment(x))
}

#' @export
ls.default <- function(x, ...) {
  base::ls(x, ...)
}

[averissimo]

Note that by using names here, we need to make some changes to teal summary table (as that should be ordered with this behavior in mind)