Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

update list of verdepcheck strategies #143

Merged
merged 1 commit into from
Jun 10, 2024
Merged

update list of verdepcheck strategies #143

merged 1 commit into from
Jun 10, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Apr 8, 2024

No description provided.

@pawelru
Copy link
Contributor Author

pawelru commented Apr 8, 2024

This requires fixes in the revdepcheck testing logic. I am working on this.

@pawelru pawelru marked this pull request as draft April 8, 2024 12:36
@pawelru
Copy link
Contributor Author

pawelru commented Apr 23, 2024

This should work after insightsengineering/verdepcheck#43 got merged

@averissimo averissimo self-assigned this Apr 23, 2024
@pawelru pawelru marked this pull request as ready for review June 10, 2024 09:22
@pawelru
Copy link
Contributor Author

pawelru commented Jun 10, 2024

Ready for review.
Manual run of the pipeline succeed here: https://github.com/insightsengineering/scda.2022/actions/runs/9445454461

Melkiades
Melkiades approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!!!

@pawelru pawelru merged commit ccdc93d into main Jun 10, 2024
54 of 57 checks passed
@pawelru pawelru deleted the fix_workflows branch June 10, 2024 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Melkiades Melkiades Melkiades approved these changes

Assignees

@averissimo averissimo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelru @Melkiades @averissimo