-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to close #238 #242
Conversation
shajoezhu
commented
Jan 7, 2025
•
edited
Loading
edited
Unit Tests Summary 1 files 5 suites 10s ⏱️ Results for commit 504eabe. ♻️ This comment has been updated with latest results. |
hi @BFalquet , I was wondering if this will be any breaking changes on your end? |
hi @averissimo , i was wondering if you could give this a try? does this resolve your problem? thanks |
If the message makes sense from SME perspective, then that looks good from my end 👍 Thanks!! |
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Joe Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!!