Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to close #238 #242

Merged
merged 3 commits into from
Jan 7, 2025
Merged

attempt to close #238 #242

merged 3 commits into from
Jan 7, 2025

Conversation

shajoezhu
Copy link
Collaborator

@shajoezhu shajoezhu commented Jan 7, 2025

> library(rlistings)
Loading required package: formatters

Attaching package: ‘formatters’

The following object is masked from ‘package:base’:

    %||%

Loading required package: tibble
> result <- tibble::tibble(col1 = character(0L), col2 = character(0L), col3 = character(0L))
> 
> listing <- rlistings::as_listing(result)
> 
> sprintf("Rows: %d // Columns: %d", nrow(listing), ncol(listing))
[1] "Rows: 0 // Columns: 3"
> 
> print(listing)
[1] "No observation in the listing object."

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Unit Tests Summary

  1 files   5 suites   10s ⏱️
 41 tests 31 ✅ 10 💤 0 ❌
111 runs  96 ✅ 15 💤 0 ❌

Results for commit 504eabe.

♻️ This comment has been updated with latest results.

@shajoezhu
Copy link
Collaborator Author

hi @BFalquet , I was wondering if this will be any breaking changes on your end?

@shajoezhu
Copy link
Collaborator Author

hi @averissimo , i was wondering if you could give this a try? does this resolve your problem? thanks

@averissimo
Copy link
Contributor

averissimo commented Jan 7, 2025

If the message makes sense from SME perspective, then that looks good from my end 👍

Thanks!!

@shajoezhu shajoezhu enabled auto-merge (squash) January 7, 2025 13:54
@shajoezhu shajoezhu disabled auto-merge January 7, 2025 15:44
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: Joe Zhu <[email protected]>
@shajoezhu shajoezhu enabled auto-merge (squash) January 7, 2025 16:11
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!!

@shajoezhu shajoezhu merged commit 9c050e1 into main Jan 7, 2025
25 checks passed
@shajoezhu shajoezhu deleted the 238_print branch January 7, 2025 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants