Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rlistings cheatsheet #200

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Create rlistings cheatsheet #200

merged 2 commits into from
Mar 4, 2024

Conversation

edelarua
Copy link
Contributor

Closes #190

Copy link
Contributor

github-actions bot commented Feb 29, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 377-380, 384-387, 420-423
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: f47c1d8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Unit Tests Summary

 1 files   4 suites   5s ⏱️
34 tests 27 ✅  7 💤 0 ❌
86 runs  75 ✅ 11 💤 0 ❌

Results for commit f47c1d8.

♻️ This comment has been updated with latest results.

@shajoezhu
Copy link
Collaborator

hi @edelarua , this looks really great! Thanks for making a first stab, i was wondering if we should try and use the same example, so it is eaiser for referencing.

@shajoezhu shajoezhu self-assigned this Feb 29, 2024
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Emily!!!! I am wondering if we could add also the ref footnote vignette (it is a workaround ofc) in the decoration part. What do you think?

@KlaudiaBB we need to advertise this and {rtables} one asap ;)

@edelarua
Copy link
Contributor Author

Great job Emily!!!! I am wondering if we could add also the ref footnote vignette (it is a workaround ofc) in the decoration part. What do you think?

Since we don't explicitly support ref footnotes (i.e. no functions in rlistings to create these) I thought it might be best not to include it on the cheatsheet, or just to include a link the vignette article on ref footnotes. What are your thoughts?

@Melkiades
Copy link
Contributor

Great job Emily!!!! I am wondering if we could add also the ref footnote vignette (it is a workaround ofc) in the decoration part. What do you think?

Since we don't explicitly support ref footnotes (i.e. no functions in rlistings to create these) I thought it might be best not to include it on the cheatsheet, or just to include a link the vignette article on ref footnotes. What are your thoughts?

It makes sense, I just wanted to have it for completeness, but it is ok w/o too

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thanks @edelarua

@Melkiades Melkiades merged commit 170dfb3 into main Mar 4, 2024
20 checks passed
@Melkiades Melkiades deleted the 190_cheatsheet@main branch March 4, 2024 08:50
@shajoezhu
Copy link
Collaborator

add news

@KlaudiaBB
Copy link

KlaudiaBB commented Mar 4, 2024

Great job Emily!!!! I am wondering if we could add also the ref footnote vignette (it is a workaround ofc) in the decoration part. What do you think?

@KlaudiaBB we need to advertise this and {rtables} one asap ;)

This week we are meeting with POs to discuss release comms, I will mention this topic if time permits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a cheatsheet
4 participants