-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vignette on referential footnotes workaround #184
Conversation
Code Coverage Summary
Diff against main
Results for commit: 0d97b1e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance Difference
Results for commit 12fc835 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edelarua , it looks nice. Though with content I have a few proposals.
- Use the first 25 rows of the ex_adae data
- Make arm column as the first column
- use "Analysis Start Relative Day" $ASTDY variable, and adding footnotes to it.
- Footnotes as "* Study day derived from imputed onset date. \n** Duration derived from imputed onset date and/or end date."
Consider this example
aa = adae[c("USUBJID", "ASTDY")]
aa$ASTDY[3] = paste0(aa$ASTDY[3], "*")
as.factor(aa$ASTDY)
you will see
[1] 251 304 497* 608 259 303 493 600 635 730 22 181 702 48 200 392 403 39 65
[20] 95 160 292 460 470 476
25 Levels: 160 181 200 22 251 259 292 303 304 39 392 403 460 470 476 48 493 497* 600 608 635 ... 95
you will need to manipulate the date such it is sorted by values, e.g.
22 39 95 48 95 160 ... 493 497* 600 608 635
So when display, you can sort this column by its levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @edelarua , it looks really good! Thanks. made some minor suggestions
Co-authored-by: Joe Zhu <[email protected]> Signed-off-by: Emily de la Rua <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! Thanks a lot Em!
Closes #176