Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vignette on referential footnotes workaround #184

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

edelarua
Copy link
Contributor

Closes #176

Copy link
Contributor

github-actions bot commented Nov 29, 2023

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 374-377, 381-384, 417-420
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 0d97b1e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
export 💚 $2.64$ $-1.22$ $0$ $0$ $0$ $0$
paginate_listing 💚 $4.72$ $-2.21$ $0$ $0$ $0$ $0$

Results for commit 12fc835

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Unit Tests Summary

  1 files    4 suites   5s ⏱️
32 tests 25 ✔️ 7 💤 0
80 runs  71 ✔️ 9 💤 0

Results for commit 0d97b1e.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu self-assigned this Nov 30, 2023
@shajoezhu shajoezhu requested review from shajoezhu and removed request for Melkiades and ayogasekaram November 30, 2023 05:50
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edelarua , it looks nice. Though with content I have a few proposals.

  1. Use the first 25 rows of the ex_adae data
  2. Make arm column as the first column
  3. use "Analysis Start Relative Day" $ASTDY variable, and adding footnotes to it.
  4. Footnotes as "* Study day derived from imputed onset date. \n** Duration derived from imputed onset date and/or end date."

Consider this example

aa = adae[c("USUBJID", "ASTDY")]
aa$ASTDY[3] = paste0(aa$ASTDY[3], "*")
as.factor(aa$ASTDY)

you will see

[1] 251  304  497* 608  259  303  493  600  635  730  22   181  702  48   200  392  403  39   65  
[20] 95   160  292  460  470  476 
25 Levels: 160 181 200 22 251 259 292 303 304 39 392 403 460 470 476 48 493 497* 600 608 635 ... 95

you will need to manipulate the date such it is sorted by values, e.g.

22 39 95 48 95 160 ... 493 497* 600 608 635

So when display, you can sort this column by its levels

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @edelarua , it looks really good! Thanks. made some minor suggestions

Co-authored-by: Joe Zhu <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
@shajoezhu shajoezhu enabled auto-merge (squash) December 1, 2023 04:44
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thanks a lot Em!

@shajoezhu shajoezhu merged commit 2d09bb9 into main Dec 1, 2023
23 checks passed
@shajoezhu shajoezhu deleted the 176_ref_footnotes_vignette@main branch December 1, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vignette for Referential footnotes workaround
2 participants