Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GITHUB_PAT for authentication #398

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Add GITHUB_PAT for authentication #398

merged 1 commit into from
Sep 27, 2023

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Sep 26, 2023

For theValidatoR action.

@cicdguy cicdguy requested a review from gowerc September 26, 2023 15:39
@cicdguy cicdguy self-assigned this Sep 26, 2023
@gowerc gowerc merged commit 272cf5f into main Sep 27, 2023
@cicdguy cicdguy deleted the add-missing-env-vars branch September 27, 2023 16:29
@gowerc
Copy link
Collaborator

gowerc commented Sep 27, 2023

@cicdguy - The above PR did not work and resulted in an error still: https://github.com/insightsengineering/rbmi/actions/runs/6328786155/job/17187740119

@gowerc
Copy link
Collaborator

gowerc commented Sep 27, 2023

Is there a better way of testing this other than having to blindly accept PRs and then create a release ?

@cicdguy
Copy link
Contributor Author

cicdguy commented Sep 27, 2023

Is there a better way of testing this other than having to blindly accept PRs and then create a release ?

Yes there is. We need to change the event type.

Also, is this workflow critical for your package or is it something that's a "nice to have"? And is rbmi in a position to use IDR workflows or does it want to have its own custom workflows like it does now?

@gowerc
Copy link
Collaborator

gowerc commented Sep 27, 2023

I was never fussed about this workflow; it was something that @epijim signed us up to use as to act as an example I think but I've never been involved in its usage / maintenance.

I am more than happy for rbmi to upgrade to using the proper IDR workflows we even have a development item for it (#395).

That being said some general notes about our current setup ...

EDIT - Moved notes on our current pipelines to the respective ticket so its not lost as this is a closed PR (#395)

@cicdguy
Copy link
Contributor Author

cicdguy commented Sep 27, 2023

The notes are good feedback for us to incorporate into the IDR workflows. We don't have some of these so we should be able to bake it into our workflows fairly easily.

@gowerc
Copy link
Collaborator

gowerc commented Sep 29, 2023

In terms of the theValidatoR workflow specifically I am wondering how we should proceed then. Personally I am happy to disable it entirely though I'm not sure if @epijim / @danielinteractive has any objections to that. If they'd rather we keep it whats the next steps for debugging this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants