Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra #244

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Add extra #244

merged 6 commits into from
Jun 25, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jun 21, 2024

No description provided.

@pawelru pawelru requested a review from a team as a code owner June 21, 2024 09:00
@pawelru pawelru mentioned this pull request Jun 21, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024 •
edited
Loading

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@pawelru
Copy link
Contributor Author

pawelru commented Jun 21, 2024

I have read the CLA Document and I hereby sign the CLA

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 896d979

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024 •
edited
Loading

Unit Tests Summary

3 tests   3 ✅  7s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit 896d979.

♻️ This comment has been updated with latest results.

cicdguy
cicdguy approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicked a bit, but looks good.

.github/workflows/verdepcheck.yaml Outdated Show resolved Hide resolved
@pawelru pawelru linked an issue Jun 21, 2024 that may be closed by this pull request
[Feature Request]: Add hint to install indirect dependency on a newer snapshot insightsengineering/verdepcheck#50
Closed
2 tasks
@pawelru @walkowif
Update .github/workflows/verdepcheck.yaml
896d979 
Co-authored-by: walkowif <[email protected]>
Signed-off-by: Pawel Rucki <[email protected]>
@cicdguy
Copy link
Contributor

cicdguy commented Jun 25, 2024

@pawelru - feel free to merge when you feel like it

@pawelru pawelru merged commit e0a8dbe into main Jun 25, 2024
11 of 20 checks passed
@pawelru pawelru deleted the add_extra branch June 25, 2024 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@walkowif walkowif walkowif left review comments

@cicdguy cicdguy cicdguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add hint to install indirect dependency on a newer snapshot
3 participants
@pawelru @cicdguy @walkowif