Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto-commits for styler workflow #227

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented May 6, 2024

Disable auto commits until the unicode styling issues have been fixed.

Disable auto commits until the unicode styling issues have been fixed.

Signed-off-by: cicdguy <[email protected]>
@cicdguy cicdguy requested a review from pawelru May 6, 2024 14:01
@cicdguy cicdguy requested a review from a team as a code owner May 6, 2024 14:01
@cicdguy cicdguy self-assigned this May 6, 2024
@cicdguy cicdguy changed the title Disable auto-commits Disable auto-commits for styler workflow May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d789641

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 6, 2024

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit d789641.

♻️ This comment has been updated with latest results.

Comment on lines 161 to 163
# if: >
# inputs.auto-update
# && steps.check_files.outputs.files_exists == 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all seems to be good but wouldn't be easier just to introduce if FALSE ? :) just thinking loud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debating that also but false in JS and YAML are the same - and didn't want to keep it ambiguous to the expression resolver.

@cicdguy cicdguy enabled auto-merge (squash) May 6, 2024 14:26
@cicdguy cicdguy disabled auto-merge May 6, 2024 14:27
@cicdguy cicdguy merged commit 365dd32 into main May 6, 2024
23 of 24 checks passed
@cicdguy cicdguy deleted the disable-styler-auto-commits branch May 6, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants