Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strategies on R min deps check workflow #175

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Update strategies on R min deps check workflow #175

merged 2 commits into from
Aug 30, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 18, 2023 •
edited
Loading

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized before being ready to review.

Change in code

  • Change branch in verdepcheck-action from new-strategies back to @main

PRS

Changes description

  • Documentation update on strategy, replacing min with min_isolate and min_cohort

@averissimo averissimo mentioned this pull request Jul 18, 2023
Closed
55 tasks
@averissimo averissimo marked this pull request as ready for review August 30, 2023 14:58
@averissimo averissimo requested a review from a team as a code owner August 30, 2023 14:58
@averissimo averissimo mentioned this pull request Aug 30, 2023
Merged
@averissimo averissimo enabled auto-merge (squash) August 30, 2023 15:01
@averissimo averissimo merged commit 77d0094 into main Aug 30, 2023
35 of 38 checks passed
@averissimo averissimo deleted the new-verdepcheck-strategy branch August 30, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelru pawelru pawelru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averissimo @pawelru