Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip vbump] release v0.1.8 #167

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[skip vbump] release v0.1.8 #167

merged 1 commit into from
Oct 24, 2024

Conversation

BFalquet
Copy link
Contributor

[skip vbump]

release v0.1.8

#166

thank you for the review

@BFalquet BFalquet requested a review from clarkliming as a code owner October 24, 2024 12:03
@BFalquet BFalquet added chevron release Pertaining to a software release labels Oct 24, 2024
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you

@clarkliming
Copy link
Contributor

i will create a release in cran later

Copy link
Contributor

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------
R/assertions.R            73       0  100.00%
R/co_relevels.R           17       0  100.00%
R/cut_by_group.R          15       0  100.00%
R/explicit_na.R           26       0  100.00%
R/filter.R                75       0  100.00%
R/join_adsub_adsl.R       92       8  91.30%   166-173
R/pivot.R                 59       0  100.00%
R/propagate.R             22       0  100.00%
R/reformat.R              80       0  100.00%
R/render_safe.R           55       1  98.18%   50
R/rules.R                 72       0  100.00%
R/unite.R                 31       0  100.00%
R/utils.R                 21       2  90.48%   72-73
R/zzz.R                    3       3  0.00%    4-6
TOTAL                    641      14  97.82%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/assertions.R           +19       0  +100.00%
R/filter.R                +2       0  +100.00%
R/join_adsub_adsl.R      +26       0  +3.43%
R/pivot.R                -14       0  +100.00%
R/reformat.R             +25       0  +100.00%
R/render_safe.R          +17       0  +0.81%
R/rules.R                +19      -1  +1.89%
R/utils.R                 -6      +2  -9.52%
TOTAL                    +88      +1  +0.17%

Results for commit: 164e8ba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Unit Tests Summary

  1 files   13 suites   1s ⏱️
107 tests 104 ✅ 3 💤 0 ❌
350 runs  345 ✅ 5 💤 0 ❌

Results for commit 164e8ba.

♻️ This comment has been updated with latest results.

@BFalquet
Copy link
Contributor Author

i will create a release in cran later

Honestly, I think we don't need to do rush.

@clarkliming
Copy link
Contributor

i will create a release in cran later

Honestly, I think we don't need to do rush.

after all the ticks in #166 are finished

@BFalquet BFalquet merged commit c1fb3a5 into main Oct 24, 2024
42 checks passed
@BFalquet BFalquet deleted the 166-release-018@main branch October 24, 2024 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@clarkliming
Copy link
Contributor

wait this is merge to main, and main bumped version?

@BFalquet BFalquet restored the 166-release-018@main branch October 31, 2024 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chevron release Pertaining to a software release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants