Skip to content

Commit

Permalink
Adds min package version (#111)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
- #96

### 🔴 Checklist for PR Reviewer

### 🔴 Checklist for PR Reviewer

- [x] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Sep 12, 2023
1 parent cbb488f commit 414ea5f
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 13 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/scheduled.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Scheduled 🕰️

on:
schedule:
- cron: '45 3 * * 0'
workflow_dispatch:

jobs:
dependency-test:
strategy:
fail-fast: false
matrix:
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
GCHAT_WEBHOOK: ${{ secrets.GCHAT_WEBHOOK }}
with:
strategy: ${{ matrix.test-strategy }}
additional-env-vars: |
PKG_SYSREQS_DRY_RUN=true
40 changes: 27 additions & 13 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,45 @@ License: Apache License 2.0 | file LICENSE
Depends:
R (>= 4.0.0)
Imports:
checkmate (>= 2.0),
dplyr,
checkmate (>= 2.1.0),
dplyr (>= 1.1.0),
forcats (>= 1.0.0),
glue,
magrittr,
glue (>= 1.0.0),
magrittr (>= 1.5),
methods,
rlang,
stringr,
tibble,
yaml
rlang (>= 1.0.0),
stringr (>= 1.4.1),
tibble (>= 1.2),
yaml (>= 2.1.15)
Suggests:
knitr,
rmarkdown,
testthat (>= 3.0.0),
withr
knitr (>= 1.42),
rmarkdown (>= 2.19),
testthat (>= 3.0.4),
withr (>= 2.1.0)
VignetteBuilder:
knitr
Config/Needs/verdepcheck:
mllg/checkmate,
tidyverse/dplyr,
tidyverse/forcats,
tidyverse/glue,
tidyverse/magrittr,
r-lib/rlang,
tidyverse/stringr,
tidyverse/tibble,
yaml=vubiostat/r-yaml,
yihui/knitr,
rstudio/rmarkdown,
r-lib/testthat,
r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
Config/testthat/edition: 3
Encoding: UTF-8
Language: en-US
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
Collate:
Collate:
'assertions.R'
'co_relevels.R'
'cut_by_group.R'
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* `empty_rule` is removed now. `rule()` will create a normal `rule` object.
* By default `rule` are converting empty space `""` to `NA` upon reformatting.
* `list2rule` now tolerates duplicated rules with different names.
* Specified minimal version of package dependencies.

# dunlin 0.1.4

Expand Down

0 comments on commit 414ea5f

Please sign in to comment.