-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend types accepted by DatasetContext to include (SolidDataset & WithAcp) #219
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ABhat00 Could you clarify what error you're running into? Anything that accepts a SolidDataset
should also accept a (SolidDataset & WithAcp)
as far as I'm aware (and a (SolidDataset & WithResourceInfo)
, for that matter).
Right now, the DatasetContext component will accept a |
@ABhat00 Ah I see - that requires using a generic to link the input type to the output type. See for example how we've done that for Also note that your |
This commit allows the DatasetContext component to be used with (SolidDataset & WithAcp)
Checklist
index.ts
, if applicable.