Fix IdP logout in node #3751
Merged
Fix IdP logout in node #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IdP logout no longer fails in Node if the session was restored from storage (using `getSessionFromStorage`), which is the typical use case of how the session should be retrieved.
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
commented
Oct 30, 2024
There was a problem hiding this comment.
This helped testing the RP-initiated logout locally
| @@ -74,6 +74,7 @@ export default class ClientAuthentication extends ClientAuthenticationBase { | |||
|
|
|||
| if (loginReturn !== undefined) { | |||
| this.fetch = loginReturn.fetch; | |||
| this.boundLogout = loginReturn.getLogoutUrl; | |||
There was a problem hiding this comment.
The logout needs to be bound on a successful login, because that's the context in which the tokens are available (because of our scope-based security approach).
| @@ -38,6 +38,7 @@ export const standardOidcOptions: IOidcOptions = { | |||
| claimsSupported: [], | |||
| scopesSupported: ["openid"], | |||
| grantTypesSupported: ["authorization_code"], | |||
| endSessionEndpoint: "https://example.com/end-session", | |||
There was a problem hiding this comment.
This is for the test mock
| @@ -181,6 +181,7 @@ describe("RefreshTokenOidcHandler", () => { | |||
| }), | |||
| )) as SolidClientAuthnCore.LoginResult; | |||
| expect(result).toBeDefined(); | |||
| expect(result?.getLogoutUrl).toBeDefined(); | |||
There was a problem hiding this comment.
This tests the non-regression
Comment on lines
+226
to
+230
| getLogoutUrl: maybeBuildRpInitiatedLogout({ | ||
| idTokenHint: accessInfo.idToken, | ||
| endSessionEndpoint: | ||
| oidcLoginOptions.issuerConfiguration.endSessionEndpoint, | ||
| }), |
There was a problem hiding this comment.
This ensures the ID token is bound to the logout URL when doing the refresh token flow.
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
acoburn
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IdP logout no longer fails in Node if the session was restored from storage (using
getSessionFromStorage), which is the typical use case of how the session should be retrieved.