WALLET-388: Retrieve resource and send to the Wallet Backend service. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling the collect endpoint
edwardsph
reviewed
Jul 25, 2024
There was a problem hiding this comment.
That works but can we simplify what is needed from the QR code as we can work out the content type when we fetch the resource. Perhaps @maxleonard or @seilagonzalez would need to comment on this.
It might be but I don't think we should change that as part of this work. I want to keep this focused on replacing the |
jholleran
deleted the
feature/WALLET-388-retrieve-resource-and-sent-to-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Frontend application to retrieve resource and send to the Wallet Backend service when scanning a QR code. It no longer calls the collect endpoint and now used the existing
PUT /walletendpoint.The
/wallet/collectendpoint is going to be removed to prevent a SSRF attack on the Wallet Backend service.Also added some error handling but there is more to do here to give a proper message to the user that something went wrong. It could also perform some retries. These issues and improvements will need to be handled in another issue.