feat: graphql int64 support #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te deps add explicit dep to graphql-tag, dep to json-bigint, bump other deps
mkazlauskas
force-pushed
the
feat/graphql-int64-support
branch
from
b5de5d8 to
de488b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Large integer numbers are supported by dgraph as Int64 scalar type. Parsing large integer from JSON request body will lose precision as it can be larger than Number.MAX_SAFE_INTEGER.
Proposed Solution
number | bigintto reflect how the new serializer worksImportant Changes Introduced
Add a script for developers to patch
jest-workeruntil this issue is resolved