Skip to content

LW-12881 Make KoraLabsHandleProvider compliant with bitcoin #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

iccicci
Copy link
Collaborator

@iccicci iccicci commented May 20, 2025

Context

We need to make Lace able to resolve ADA handle bitcoin addresses.

Proposed Solution

  • Changed the HandleResolution type to include the bitcoin address.
  • Added the new resolution to KoraLabsHandleProvider.

@iccicci iccicci force-pushed the feat/LW-12881-bitcoin-handle branch 2 times, most recently from 29de791 to 94abd03 Compare May 20, 2025 12:50
@iccicci iccicci marked this pull request as ready for review May 20, 2025 16:39
AngelCastilloB
AngelCastilloB previously approved these changes May 21, 2025
Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@iccicci iccicci force-pushed the feat/LW-12881-bitcoin-handle branch from b0bbdea to c625ef2 Compare May 21, 2025 15:32
@iccicci iccicci merged commit e467169 into master May 21, 2025
7 of 8 checks passed
@iccicci iccicci deleted the feat/LW-12881-bitcoin-handle branch May 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants