refactor(cardano-services-client): use CIP129 when querying dreps/:drepId - LW-12316 #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceahasegan
force-pushed
the
refactor/lw-12316-use-cip129-to-query-drep
branch
from
9b832ed to
5f2bc8a
Compare
greatertomi
previously approved these changes
Feb 11, 2025
mirceahasegan
force-pushed
the
refactor/lw-12316-use-cip129-to-query-drep
branch
from
5f2bc8a to
9c57b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the inception of governance DReps ids were bech32 encoded using CIP105 spec.
Later a new standard, CIP129 because the defacto bech32 way to encode DRep ids
Blockfrost supports querying for specific DReps using both standards.
We should aim to use a single format throughout the code, to avoid confusion and to be consistent
Proposed Solution
Important Changes Introduced