Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partial tx history LW-12070 #1560

Merged
merged 7 commits into from
Jan 20, 2025
Merged

feat: partial tx history LW-12070 #1560

merged 7 commits into from
Jan 20, 2025

Conversation

mkazlauskas
Copy link
Member

Context

Wallets with huge transaction history take a very long time to load

Proposed Solution

Limit # of transactions fetched for initial load

For more details see commits

Important Changes Introduced

@mkazlauskas mkazlauskas force-pushed the feat/partial-tx-history branch 12 times, most recently from f7dd043 to af120ee Compare January 20, 2025 08:20
This is required to be able to fetch n latest transactions
Not implemented in db-sync provider

Also, fix BlockfrostChainHistoryProvider to
- pass through pagination options
- stop fetching when reach the limit from user specified pagination options
it can be either key hash or script hash
emits transactions that are added to history after initial load
@mkazlauskas mkazlauskas force-pushed the feat/partial-tx-history branch 3 times, most recently from d15e098 to 5eb960e Compare January 20, 2025 12:51
…assertions

assert based on whether stake credential was initally registered
and how many epochs have passed since initial state:
- if it was registered, then delegation will take effect next epoch
- if it wasn't registered, then it will take 2 epochs

also, fix balance deposit assertion that as duplicated
BaseWallet will load only last n transactions on initial load

BREAKING CHANGE: remove BaseWallet stake pool and drep provider dependency
- add RewardAccountInfoProvider as a new BaseWallet dependency
@mkazlauskas mkazlauskas force-pushed the feat/partial-tx-history branch from 5eb960e to 40a3ce0 Compare January 20, 2025 14:09
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work here @mkazlauskas

@rhyslbw rhyslbw merged commit 05b1dcb into master Jan 20, 2025
5 of 6 checks passed
@rhyslbw rhyslbw deleted the feat/partial-tx-history branch January 20, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants