-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: partial tx history LW-12070 #1560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7dd043
to
af120ee
Compare
This is required to be able to fetch n latest transactions Not implemented in db-sync provider Also, fix BlockfrostChainHistoryProvider to - pass through pagination options - stop fetching when reach the limit from user specified pagination options
it can be either key hash or script hash
emits transactions that are added to history after initial load
d15e098
to
5eb960e
Compare
…assertions assert based on whether stake credential was initally registered and how many epochs have passed since initial state: - if it was registered, then delegation will take effect next epoch - if it wasn't registered, then it will take 2 epochs also, fix balance deposit assertion that as duplicated
BaseWallet will load only last n transactions on initial load BREAKING CHANGE: remove BaseWallet stake pool and drep provider dependency - add RewardAccountInfoProvider as a new BaseWallet dependency
5eb960e
to
40a3ce0
Compare
mkazlauskas
commented
Jan 20, 2025
mkazlauskas
commented
Jan 20, 2025
rhyslbw
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work here @mkazlauskas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Wallets with huge transaction history take a very long time to load
Proposed Solution
Limit # of transactions fetched for initial load
For more details see commits
Important Changes Introduced