Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Modernize dependencies and QA #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmazzap
Copy link
Contributor

@gmazzap gmazzap commented Mar 1, 2024

  • Require PHP 7.4+ and WP 6.1+
  • Requiring WP 6.1 we can just rely on is_login() function and cleanup our method
  • Improve QA
    • Added lint job and execution on pull requests
    • Execute QA jobs for 8.3
    • Updated code styles to v2 and fixed new issues reported
    • Updated PHPUnit - Removed unused Psalm autoloader
    • Switched to wp-stubs-version
  • Better types documentation in doc blocs
  • Added requirements and updated license year in README

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Maintenance.

What is the current behavior? (You can also link to an open issue here)

N/A

What is the new behavior (if this is a feature change)?

N/A

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

Other information:

- Require PHP 7.4+ and WP 6.1+
- Requiring WP 6.1 we can just rely on is_login() function
- Improve QA
        - Added lint job and execution on pull requests
        - Updated code styles to v2 and fixed new issues reported
        - Updated PHPUnit
        - Removed unused Psalm autoloader
        - Switched to wp-stubs-version
- Better type documentation
- Added requirements and updated license year in README
@gmazzap gmazzap requested a review from Chrico March 1, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant