[wip] composer psalm:ci works on my local #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangrufus
force-pushed
the
wp-no-content
branch
from
c3e96f5 to
071a8c5
Compare
|
@tangrufus I'm actually fine with this approach, we have to add a new entry time by time but I don't see it as a big deal to be honest. Is there anything else or can we merge it as it is? I see all checks are passing. |
|
Change the PR title and commit title. Then you can merge. When psalm complains function not found, do not stub https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/noop.php Stub the real function definition instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@widoz please take over