Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to load selected entrypoints #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nlemoine
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Add the ability to load a selected entrypoints
  • Add BudEntrypointsLoader

What is the current behavior? (You can also link to an open issue here)

The EncoreEntrypointsLoader actually loads all assets found in entrypoints.json but this might result in loading non wanted assets if you don't (or can't) adhere to the location resolver naming convention.

What is the new behavior (if this is a feature change)?

Add an (array) $entrypoints parameter to the load method so you can manually set the desired entrypoints.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

The Loader interface remains unchanged so this should not.

Other information:

I also added a BudEntrypointsLoader which is basically similar to EncoreEntrypointsLoader besides it does not have an entrypoints key.

- Add the ability to load a selected entrypoints
- Add BudEntrypointsLoader
@nlemoine nlemoine force-pushed the selected-entrypoints-loader branch from f0a661a to ed54da0 Compare December 15, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant