Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FactorMappingTable for simple categorical tables (#15) #19

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Implement FactorMappingTable for simple categorical tables (#15) #19

merged 4 commits into from
Oct 27, 2024

Conversation

inpowell
Copy link
Owner

This PR implements a FactorMappingTable, that extends BaseMappingTable to build simple categorical tables.

It includes a preprocessing step that allows unspecified categories to be mapped to .other, similar to RangeMappingTable.

On my computer - which is very good to finally have set up:

── R CMD check results ───────── modulartabler 0.1.0 ────
Duration: 13.5s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

R CMD check succeeded

@inpowell inpowell linked an issue Oct 26, 2024 that may be closed by this pull request
Add a simple FactorMappingTable #15
Closed
PeterM74
PeterM74 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@PeterM74 PeterM74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great addition

@inpowell inpowell merged commit b0620d9 into master Oct 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterM74 PeterM74 PeterM74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a simple FactorMappingTable
2 participants
@inpowell @PeterM74