Skip to content

Commit

Permalink
Merge branch 'lebihae/1207' into 'main'
Browse files Browse the repository at this point in the history
fix(app): correctly forward readonly prop to baseinput (closes #1207)

Closes #1207

See merge request churros/churros!260
  • Loading branch information
ewen-lbh committed Oct 22, 2024
2 parents ccb5a69 + 0c84def commit 606893c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/dry-jars-whisper.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@churros/app': patch
---

fix(app): date inputs were sometimes not editable
2 changes: 2 additions & 0 deletions packages/app/src/lib/components/BaseInputText.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
export let closeKeyboardOnEnter = false;
export let element: HTMLInputElement | undefined = undefined;
export let focused = false;
export let readonly = false;
export let help = '';
// TODO use (HTMLInputElement).valueAsDate instead
Expand Down Expand Up @@ -140,6 +141,7 @@
{name}
value={stringifyValue(value, type)}
required={required || undefined}
readonly={readonly || undefined}
{autocomplete}
{placeholder}
{...$$restProps}
Expand Down

0 comments on commit 606893c

Please sign in to comment.