Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Exchange the outdated react-autosize-textarea library #4805

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Resaki1
Copy link
Collaborator

@Resaki1 Resaki1 commented Jan 23, 2025

Description

For the note input element and the note itself, we are using the react-autosize-textarea, which was archived last year. This PR exchanged this old library with the react-textarea-autosize library, which is still being updated. This also removes the need for defining onPointerEnterCapture and onPointerLeaveCapture events.

The functionality should not have chanegd.

Changelog

  • removed react-autosize-textarea as dependency
  • added react-textarea-autosize as dependency
  • removed undefined onPointerEnterCapture and onPointerLeaveCapture events on all TextareaAutosize instances

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Resaki1 Resaki1 added the Review Needed This pull request is ready for review label Jan 23, 2025

This comment has been minimized.

@Schwehn42
Copy link
Member

amazing, the onPointerEnterCapture was actually driving me nuts

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4805.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-b1c510c

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-b1c510c

Copy link

octomind-dev bot commented Jan 31, 2025

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: b1c510c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants