Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scss warnings #4486

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: scss warnings #4486

wants to merge 2 commits into from

Conversation

Schwehn42
Copy link
Collaborator

@Schwehn42 Schwehn42 commented Sep 10, 2024

Description

Recently, the following warnings came up:

<w> 
<w> src/constants/colors.scss 235:11                                             set-base-colors()
<w> src/constants/colors.scss 255:3                                              @import
<w> src/constants/style.scss 4:9                                                 @import
<w> src/components/BoardHeader/HeaderMenu/BoardOptions/BoardOptionLink.scss 1:9  root stylesheet
<w> 
<w> You probably don't mean to use the color value gray in interpolation here.
<w> It may end up represented as gray, which will likely produce invalid CSS.
<w> Always quote color names when using them as strings or map keys (for example, "gray").
<w> If you really want to use the color value here, use '"" + $color-name'.

So I did as suggested and put the map keys "gray" and "navy" as quotes, which should hopefully fix it.

Also, another warning concerning rule order was fixed: https://sass-lang.com/d/mixed-decls

Changelog

  • Put the map keys navy and gray in quotes
  • change rule order: no declarations after nested rules

@Schwehn42 Schwehn42 added Bug This pull request or issue contains/fixes a bug Review Needed This pull request is ready for review labels Sep 10, 2024
@Schwehn42 Schwehn42 self-assigned this Sep 10, 2024
@Schwehn42 Schwehn42 changed the title fix: color map key quotation fix: scss warnings Sep 11, 2024
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4486.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-1251b15

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-1251b15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This pull request or issue contains/fixes a bug Review Needed This pull request is ready for review
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants