-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: settings dialog #4265
Open
Schwehn42
wants to merge
60
commits into
main
Choose a base branch
from
js/refactor-settings-dialog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
76088cc
add settings constants
Schwehn42 b4cd75e
add render function
Schwehn42 1348e3e
render menu items (except profile)
Schwehn42 fce7530
forgot to add export board item
Schwehn42 2d23263
make seed prop optional and add safety guard
Schwehn42 57ad812
add profile to menu items
Schwehn42 059f038
render profile using new function
Schwehn42 6935c06
useLocation to highlight active menu item
Schwehn42 daca4bc
add comments
Schwehn42 33800f7
move functions around
Schwehn42 52d950e
use keys
Schwehn42 6cd99eb
render only if enabled
Schwehn42 60caa91
add shorthand to enable all menu items
Schwehn42 9a3bbeb
add prop to router with feedback state
Schwehn42 bbcd7ab
readd and fix logic
Schwehn42 65cbeda
allow blank args
Schwehn42 f2b64db
fix key name
Schwehn42 8be188b
simplify
Schwehn42 dadd12d
move logic
Schwehn42 dd3a9b1
fix mobile breakpoint edge case
Schwehn42 bbc6502
comment
Schwehn42 1b32adc
function to determine first valid menu item
Schwehn42 c04a117
move inside useEffect
Schwehn42 ad71b9e
remove default value to allow reload
Schwehn42 dceea23
fix test
Schwehn42 00cf840
add tests
Schwehn42 f8b8114
fix import path
Schwehn42 48edcbe
fix unrelated linting warnings
Schwehn42 e8c743c
Merge branch 'refs/heads/main' into js/refactor-settings-dialog
Schwehn42 554693c
settings constant new color name
Schwehn42 938cbf1
snapshot
Schwehn42 a039b6b
Merge branch 'refs/heads/main' into js/refactor-settings-dialog
Schwehn42 8c3086a
use scrumlr logo component
Schwehn42 c357e29
rename activeMenuItem -> activeMenuKey
Schwehn42 ad7db97
menu type
Schwehn42 739ba12
refactor to MenuEntry
Schwehn42 f0d8fe8
new logic
Schwehn42 f884d84
directly use MENU_ENTRIES
Schwehn42 895d26a
merge useEffects
Schwehn42 061709b
working version: use entry value directly
Schwehn42 69d5711
simplify and comment
Schwehn42 42df10b
rename functions
Schwehn42 15b8201
inline function
Schwehn42 2afa89a
clarify comment
Schwehn42 fd1cb92
state setter function typo
Schwehn42 85936c2
use outlet context for accent color
Schwehn42 f37d5b0
make context value optional
Schwehn42 48051c6
update snapshots
Schwehn42 f21f66c
use correct colors
Schwehn42 93a98d3
update snapshot again
Schwehn42 a16da02
Merge branch 'main' into js/refactor-settings-dialog
Schwehn42 6c75c54
Merge branch 'refs/heads/main' into js/refactor-settings-dialog
Schwehn42 4a45b59
fix feedback color
Schwehn42 02aa94e
Merge branch 'refs/heads/main' into js/refactor-settings-dialog
Schwehn42 f08c197
Merge branch 'refs/heads/main' into js/refactor-settings-dialog
Schwehn42 47e8012
snapshot
Schwehn42 db1e11c
Merge branch 'main' into js/refactor-settings-dialog
Schwehn42 024a149
revert eslint rule
Schwehn42 41f7e17
readd className to BoardOptionButton
Schwehn42 31fda31
rename types/constants
Schwehn42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the accent color of the appearance tab the same, no matter if it's used within a board or for the template page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question for all of the other tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, since the color of the menu items is determined by the menu item config, it makes sense for the actual settings dialogs to use the same color instead of using hard-coded values.