refactor(landingpage): reflect elements storybook version in URL #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasHeimGalindo
temporarily deployed
to
github-pages
GitHub Actions
Inactive
TobiasHeimGalindo
temporarily deployed
to
github-pages
GitHub Actions
Inactive
janivo
requested changes
May 10, 2024
packages/landingpage/app/[lang]/_components/layout/header/versionSelect.tsx
Show resolved
Hide resolved
janivo
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1338
Review Notes: I noticed that navigating to different Storybook elements was causing an extra reload. This didn't show up when serving the page locally. To fix this, I used useMemo in the useStorybookUrl hook to prevent unnecessary recalculations of the Storybook URL unless the search parameters change. However as seen in the video this issue still occurs.
2024-04-24.12-42-39.mp4