Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-patterns): tailwind styles not being integrated #1377

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

janivo
Copy link
Collaborator

@janivo janivo commented Apr 11, 2024

Closes #1376

Proposed Changes

  • Move all dependencies to prevent version mismatches
  • Activate caching for vite build
  • Point postcss.config.js to the proper tailwind.config.js

Context

The issue arose from the inability of postcss.config.js to locate any tailwind.config.js file for processing. This was due to its expectation for tailwind.config.js to be located directly adjacent to it. Although the tailwind configuration file was correctly positioned, the introduction of Vite executors caused a change in the execution context, resulting in it being executed from our root directory where tailwind.config.js was not present.

// before introduction of vite executors
$ packages/ui-patterns > vite build // context -> packages/ui-patterns

// after introduction of vite executors
$ / > nx vite:build ui-patterns // context -> /

To resolve this issue, we need to utilize appropriate file paths within postcss.config.js to correctly reference the location of tailwind.config.js.

@janivo janivo merged commit 755bad0 into master Apr 11, 2024
4 checks passed
@janivo janivo deleted the fix/1376-ui-patterns-styling-missing branch April 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylings of Patterns Not Applied in Landing Page
2 participants