Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): added controls for CSS variables #1152

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

iandi09
Copy link
Collaborator

@iandi09 iandi09 commented Dec 29, 2023

Closes #453

  • added css variable support to story template generator
  • extracted css props for the existing stories

@iandi09 iandi09 changed the title feat(storybook) added controls for CSS variables feat(storybook): added controls for CSS variables Dec 29, 2023
@iandi09 iandi09 marked this pull request as ready for review January 2, 2024 10:13
@janivo
Copy link
Collaborator

janivo commented Jan 8, 2024

It would be cooler to extract this CSS prop from the stenci-docs.json file, so we can automatically generate the respective controls.

e.g.

/**
  * @prop --ino-avatar-size: Width and height of the ino-avatar (default:40px,size)
  */

Where the default value of 40px and the type of control (size) is extracted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Storybook Controls for Colors, Numbers, ... (for CSS Variables)
2 participants