Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Songs downloaded are sorted by their popularity #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Songs downloaded are sorted by their popularity #18

wants to merge 1 commit into from

Conversation

adimrsingh
Copy link

Numbering of filenames has been added.

Numbering of filenames has been added.
@inovachrono
Copy link
Owner

Numbering of filenames has been added.

I really appreciate this. However, I'm very sure that the songs will not be sorted based on popularity in all cases in this single function is responsible for downloading albums, playlists and artists. Also it becomes messy when transferring these to a media player. Maybe we can add another flag if someone wants them to be named and sorted based on numbering.

@adimrsingh
Copy link
Author

I really appreciate this. However, I'm very sure that the songs will not be sorted based on popularity in all cases in this single function is responsible for downloading albums, playlists and artists. Also it becomes messy when transferring these to a media player. Maybe we can add another flag if someone wants them to be named and sorted based on numbering.

As JioSaavn always sort their songs by their popularity, and since media player lists songs by their title therefore that won't be messy at all. And yes this could be added as a flag for someone like me who needs a well sorted library.

@inovachrono
Copy link
Owner

As JioSaavn always sort their songs by their popularity.

That's not true. I have already verified it for playlists and albums. The songs are never sorted by jiosaavn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants