Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(YouTube): Update Overlay buttons, add Hide live chat messages and more Start page options #50

Merged
merged 15 commits into from
May 21, 2024
Merged

feat(YouTube): Update Overlay buttons, add Hide live chat messages and more Start page options #50

merged 15 commits into from
May 21, 2024

Conversation

anddea
Copy link

@anddea anddea commented May 16, 2024 •
edited
Loading

inotia00/revanced-integrations#39

Each commit has its own conventional message that describes features and fixes.

@anddea anddea mentioned this pull request May 16, 2024
Merged
@inotia00
Copy link
Owner

Whitelist setting is not implemented.
@anddea, Please remove icons and patches related with the whitelist.

@Francesco146
Copy link

Whitelist setting is not implemented. @anddea, Please remove icons and patches related with the whitelist.

are you planning to implement it in the future? YT-Advanced is near a full implementations after the big refactor

@inotia00
Copy link
Owner

are you planning to implement it in the future? YT-Advanced is near a full implementations after the big refactor

The channel whitelist is a feature that existed in YouTube Vanced that I ported to revanced-patches around December 2022.

Release notes
https://github.com/inotia00/revanced-patches/releases/tag/v2.147.0
Source: TeamVanced/Integrations
TeamVanced/Integrations#74

Since YouTube API v1 was deprecated, I removed the channel whitelist around August 2023.

Release notes
https://github.com/inotia00/revanced-patches/releases/tag/v2.168.30

@YT-Advanced restored the code I removed, but it is not compatible with revanced-patches-4.x.x.
(Some code is still based on Vanced integration and requires refactoring.)

@Francesco146
Copy link

understood, thanks for the infos

@anddea
Copy link
Author

anddea commented May 19, 2024

I'll remove later, in 48 hours. There should be only whitelist icons, no code related to it.

@inotia00 inotia00 mentioned this pull request May 21, 2024
Merged
@inotia00
Copy link
Owner

@anddea Please review comments

@anddea
Copy link
Author

anddea commented May 21, 2024

What comments are you referring to? This PR comments, the PR where you mentioned this PR, code comments?

inotia00
inotia00 requested changes May 21, 2024
View reviewed changes
Copy link
Owner

@inotia00 inotia00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's my fault, I forgot to submit comments

src/main/kotlin/app/revanced/patches/youtube/player/overlaybuttons/OverlayButtonsPatch.kt Show resolved Hide resolved
src/main/kotlin/app/revanced/patches/youtube/player/overlaybuttons/OverlayButtonsPatch.kt Outdated Show resolved Hide resolved
@inotia00
Copy link
Owner

I tested it a while ago and all settings seem to work as intended

Can I merge PR?

@inotia00
Copy link
Owner

Thanks

@inotia00 inotia00 merged commit 84dd65f into inotia00:dev May 21, 2024
@inotia00 inotia00 mentioned this pull request May 24, 2024
Closed
4 tasks
@anddea anddea deleted the filter branch June 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inotia00 inotia00 inotia00 approved these changes

@Jobran1993 Jobran1993 Jobran1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anddea @inotia00 @Francesco146 @Jobran1993