Skip to content

Commit

Permalink
Hackfix IRender mimetype error
Browse files Browse the repository at this point in the history 
Via dask/dask-labextension#260
  • Loading branch information
@psychemedia
psychemedia committed Jun 7, 2023
1 parent 4716e6b commit bb937be
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@
"stylelint-prettier": "^2.0.0",
"typescript": "~4.1.3"
},
"resolutions": {
"@jupyterlab/rendermime-interfaces": "^3.0.0 <=3.6.3"
},
"sideEffects": [
"style/*.css",
"style/index.js"
Expand Down

4 comments on commit bb937be

@jhgoebbert
Copy link

@jhgoebbert jhgoebbert commented on bb937be Jun 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With which version of JupyterLab did you test your hackfix?
I tried it for the extension dask-labextension for the current JupyterLab version 3.6.4 and it fails:

      node_modules/@jupyterlab/rendermime/lib/widgets.d.ts(8,31): error TS2420: Class 'RenderedCommon' incorrectly implements interface 'IRenderer'.
        The types of 'title.owner.layout' are incompatible between these types.
          Type 'import("/dev/shm/dask_labextension-6.1.0/node_modules/@lumino/widgets/types/layout").Layout' is not assignable to type 'import("/dev/shm/dask_labextension-6.1.0/node_modules/@jupyterlab/rendermime-interfaces/node_modules/@lumino/widgets/types/layout").Layout'.
            Property '[Symbol.iterator]' is missing in type 'import("/dev/shm/dask_labextension-6.1.0/node_modules/@lumino/widgets/types/layout").Layout' but required in type 'import("/dev/shm/dask_labextension-6.1.0/node_modules/@jupyterlab/rendermime-interfaces/node_modules/@lumino/widgets/types/layout").Layout'.

@psychemedia
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access to the build environment I used right at the moment, but I don't think I'd pinned a JupyterLab version; so I used whatever was installed from PyPi a couple of days ago with version <4.

@psychemedia
Copy link
Contributor Author

@psychemedia psychemedia commented on bb937be Jun 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just managed to find it: jupyterlab 3.6.4 was used in the build process.

(I don't really understand the JupyterLab extension process. It's a wing and a prayer and repeated expletives process as far as I'm concerned.)

@jhgoebbert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking that. Then I have to dig deeper to find out what is wrong with dask-labextension.

Please sign in to comment.