Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix probe response sig with streaming #707

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

amh4r
Copy link
Contributor

@amh4r amh4r commented Sep 10, 2024

Summary

Fix no response signature header when streaming is enabled.

Checklist

  • Added changesets if applicable

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 8d51836

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Sep 10, 2024
@jpwilliams jpwilliams self-assigned this Sep 12, 2024
Copy link
Member

@jpwilliams jpwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I refactored the getQueryString() usage a touch - it was already spread everywhere prior to this PR.

@jpwilliams jpwilliams added the Bug Something isn't working label Sep 12, 2024
@jpwilliams jpwilliams merged commit 8c4b9ce into main Sep 12, 2024
51 of 52 checks passed
@jpwilliams jpwilliams deleted the fix-probes-with-streaming branch September 12, 2024 12:59
jpwilliams pushed a commit that referenced this pull request Sep 12, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

- [#707](#707)
[`8c4b9ce`](8c4b9ce)
Thanks [@goodoldneon](https://github.com/goodoldneon)! - Fix probe
response sig with streaming

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants