Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make headers case insensitive #691

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-socks-tan.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"inngest": patch
---

Fix header keys sometimes case sensitive
8 changes: 7 additions & 1 deletion packages/inngest/src/digitalocean.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ export const serve = (

return {
body: () => data || {},
headers: (key) => http?.headers?.[key],
headers: (key) => {
for (const [k, v] of Object.entries(http.headers)) {
if (k.toLowerCase() === key.toLowerCase()) {
return v;
}
}
},
method: () => http.method,
url: () => new URL(`${options.serveHost}${options.servePath || "/"}`),
queryString: (key) => main[key] as string,
Expand Down
9 changes: 8 additions & 1 deletion packages/inngest/src/express.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,14 @@ export const serve = (options: ServeHandlerOptions): any => {
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
body: () => req.body,
headers: (key) => {
const header = req.headers[key];
let header;
for (const [k, v] of Object.entries(req.headers)) {
if (k.toLowerCase() === key.toLowerCase()) {
header = v;
break;
}
}

return Array.isArray(header) ? header[0] : header;
},
method: () => req.method || "GET",
Expand Down
9 changes: 8 additions & 1 deletion packages/inngest/src/fastify.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,14 @@ export const serve = (
return {
body: () => req.body,
headers: (key) => {
const header = req.headers[key];
let header;
for (const [k, v] of Object.entries(req.headers)) {
if (k.toLowerCase() === key.toLowerCase()) {
header = v;
break;
}
}

return Array.isArray(header) ? header[0] : header;
},
method: () => req.method,
Expand Down
8 changes: 7 additions & 1 deletion packages/inngest/src/koa.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,13 @@ export const serve = (
body: () =>
(ctx.request as unknown as { body: Record<string, unknown> }).body,
headers: (key) => {
const header = ctx.headers[key];
let header;
for (const [k, v] of Object.entries(ctx.headers)) {
if (k.toLowerCase() === key.toLowerCase()) {
header = v;
break;
}
}

if (Array.isArray(header)) {
return header[0];
Expand Down
8 changes: 7 additions & 1 deletion packages/inngest/src/lambda.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,13 @@ export const serve = (
: "{}"
);
},
headers: (key) => event.headers[key],
headers: (key) => {
for (const [k, v] of Object.entries(event.headers)) {
if (k.toLowerCase() === key.toLowerCase()) {
return v;
}
}
},
method: () => {
return eventIsV2
? event.requestContext.http.method
Expand Down
15 changes: 11 additions & 4 deletions packages/inngest/src/next.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,17 @@ export const serve = (
const req = expectedReq as Either<NextApiRequest, NextRequest>;

const getHeader = (key: string): string | null | undefined => {
const header =
typeof req.headers.get === "function"
? req.headers.get(key)
: req.headers[key];
let header;
if (typeof req.headers.get === "function") {
header = req.headers.get(key);
} else {
for (const [k, v] of Object.entries(req.headers)) {
if (k.toLowerCase() === key.toLowerCase()) {
header = v;
break;
}
}
}

return Array.isArray(header) ? header[0] : header;
};
Expand Down
8 changes: 7 additions & 1 deletion packages/inngest/src/redwood.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,13 @@ export const serve = (
: "{}"
);
},
headers: (key) => event.headers[key],
headers: (key) => {
for (const [k, v] of Object.entries(event.headers)) {
if (k.toLowerCase() === key.toLowerCase()) {
return v;
}
}
},
method: () => event.httpMethod,
url: () => {
const scheme =
Expand Down
Loading