Update no-nested-steps.ts #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UPDATED: eslint-plugin/src/rules/no-nested-steps.ts - Updated rule to disallow use of any `step.*` within another `step.*` function - Added check to report error if `step.*` is used within another `step.*` function - issue with counting the depth of nested `step.run()` calls
🦋 Changeset detectedLatest commit: 5ae044b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jpwilliams
added
the
📦 @inngest/eslint-plugin
|
Thanks, @swiecki! Apologies this caught you out. |
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Aug 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @inngest/[email protected] ### Patch Changes - [#669](#669) [`cff63ca`](cff63ca) Thanks [@swiecki](https://github.com/swiecki)! - Fix `no-nested-steps` not catching nested steps other than `step.run()` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we had an interesting and expensive learning experience- we had pushed step.sendEvent inside step.run. As part of the retrospective I noticed the eslint plugin seemed to only be picking up step.run inside step.run, not step.invoke or step.sendEvent etc.
UPDATED: eslint-plugin/src/rules/no-nested-steps.ts
step.*within anotherstep.*functionstep.*is used within anotherstep.*functionstep.run()callsSummary
Checklist
Added a docs PR that references this PRN/A Bug fix