Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inngest.setEnvVars(env) to set env vars late on the client #665

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Jul 27, 2024

Summary

On some platforms, environment variables are sent as a function argument and are not available as a global. serve() handlers manage this transparently as they can silently retrieve the values they are passed, but Inngest clients can require manual intervention.

For these cases, we add inngest.setEnvVars(), allowing you to set environment variables at runtime and rest any URLs or configuration that was set during instantiation.

app.on("GET", "/api/send-some-event", async (c) => {
  inngest.setEnvVars(c.env);

  await inngest.send({ name: "test/event/after" });

  return c.json({ message: "Done!" });
});

Checklist

  • Added a docs PR that references this PR
  • Added unit/integration tests
  • Added changesets if applicable

Related

@jpwilliams jpwilliams added ✨ new New features, integrations, or exports prerelease/inngest Create snapshot releases for a PR for the "inngest" package. ⬆️ improvement Performance, reliability, or usability improvements labels Jul 27, 2024
@jpwilliams jpwilliams self-assigned this Jul 27, 2024
Copy link

changeset-bot bot commented Jul 27, 2024

🦋 Changeset detected

Latest commit: 6fc91b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Jul 27, 2024
@inngest-release-bot
Copy link
Collaborator

inngest-release-bot commented Jul 27, 2024

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-665. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-665

The last release was built and published from 6fc91b9.

@jpwilliams jpwilliams merged commit 1a4962d into main Jul 29, 2024
46 checks passed
@jpwilliams jpwilliams deleted the feat/allow-setting-client-env-vars branch July 29, 2024 12:30
jpwilliams pushed a commit that referenced this pull request Jul 29, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Minor Changes

- [#665](#665)
[`1a4962d`](1a4962d)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add
`inngest.setEnvVars(env)` to set env vars late on the client

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package ✨ new New features, integrations, or exports prerelease/inngest Create snapshot releases for a PR for the "inngest" package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants