Skip to content

Add Prefix Option https://github.com/ingydotnet/git-subrepo/issues/319 #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FanchTheSystem
Copy link

Please comment or merge. Ref: #319

If merged, I will try : #318

Thank you !

Copy link
Collaborator

@grimmySwe grimmySwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor comment.

lib/git-subrepo Outdated
@@ -123,9 +124,10 @@ main() {

local override_remote= # Remote specified with -r
local override_branch= # Remote specified with -b

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this extra white space.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;)

@PapsOu
Copy link

PapsOu commented Feb 15, 2018

@grimmySwe : Do you have any news about this PR ?

@ingydotnet
Copy link
Owner

Can you target this PR against master? The release/0.4.0 branch has now been merged.

@FanchTheSystem FanchTheSystem changed the base branch from release/0.4.0 to master November 13, 2018 22:06
@FanchTheSystem
Copy link
Author

Can you target this PR against master? The release/0.4.0 branch has now been merged.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants