Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusive accordion #2372

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

johncliffrule
Copy link
Contributor

This PR adds a new property called "exclusive" , which when enabled allows only one accordion to be open at any given time.

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 87a22d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@gerjanvangeest gerjanvangeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johncliffrule thanks for the addition to the accordion 💪

Can you add some tests for exclusive?
Can you also add a changeset (npm run changeset) to which helps us to add this change to the changelog.

@okadurin
Copy link
Collaborator

okadurin commented Oct 1, 2024

The app fails to render the dynamic examples when running via npm run start when navigating to http://localhost:8001/components/accordion/use-cases/

@johncliffrule
Copy link
Contributor Author

@johncliffrule thanks for the addition to the accordion 💪

Can you add some tests for exclusive? Can you also add a changeset (npm run changeset) to which helps us to add this change to the changelog.

Hi, you can now see tests added
And for changeset I see this message
image
WARNING: Releasing a major version for @lion/ui will be its first major release.
🦋 If you are unsure if this is correct, contact the package's maintainers before committing this changeset.

Is this fine?

@johncliffrule
Copy link
Contributor Author

The app fails to render the dynamic examples when running via npm run start when navigating to http://localhost:8001/components/accordion/use-cases/

@tlouisse did you check this?

@gerjanvangeest
Copy link
Member

WARNING: Releasing a major version for @lion/ui will be its first major release.
🦋 If you are unsure if this is correct, contact the package's maintainers before committing this changeset.

Is this fine?

You should not select the major version, but add this as a minor.
The changeset is just an md file, so it can be adjusted afterwards if needed.

@tlouisse
Copy link
Member

tlouisse commented Oct 1, 2024

The app fails to render the dynamic examples when running via npm run start when navigating to http://localhost:8001/components/accordion/use-cases/

@tlouisse did you check this?

Yes, I just pushed the fix and a changeset 👍

@gerjanvangeest gerjanvangeest merged commit 4696ad7 into ing-bank:master Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants