-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclusive accordion #2372
Exclusive accordion #2372
Conversation
🦋 Changeset detectedLatest commit: 87a22d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johncliffrule thanks for the addition to the accordion 💪
Can you add some tests for exclusive
?
Can you also add a changeset (npm run changeset
) to which helps us to add this change to the changelog.
The app fails to render the dynamic examples when running via |
Hi, you can now see tests added Is this fine? |
@tlouisse did you check this? |
You should not select the |
Yes, I just pushed the fix and a changeset 👍 |
This PR adds a new property called "exclusive" , which when enabled allows only one accordion to be open at any given time.