Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard typing #2371

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix keyboard typing #2371

wants to merge 3 commits into from

Conversation

okadurin
Copy link
Collaborator

@okadurin okadurin commented Oct 1, 2024

Replace mimicUserTyping in some tests with sendKeys to unblock the PR related to the overlay bug

Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: cbb9b0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tlouisse
Copy link
Member

tlouisse commented Oct 1, 2024

Would it be possible to solve this inside all "mimic methods" that we expose here?
https://github.com/ing-bank/lion/blob/master/packages/ui/components/combobox/test-helpers/combobox-helpers.js#L40

(so that we only change these external files and fix it inside our current abstractions)

@okadurin
Copy link
Collaborator Author

okadurin commented Oct 1, 2024

Would it be possible to solve this inside all "mimic methods" that we expose here? https://github.com/ing-bank/lion/blob/master/packages/ui/components/combobox/test-helpers/combobox-helpers.js#L40

(so that we only change these external files and fix it inside our current abstractions)

@tlouisse Good point! I think we need to make a replacement for all keyboard interaction cases we have in our tests. At least for components that use OverlayMixin. That is because the actual source code fix is in the OverlayMixin and not in the combobox component. Otherwise we cannot be sure that the rest of the tests are not false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants