Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Introduce Playwright for e2e testing #2370

Closed
wants to merge 32 commits into from

Conversation

okadurin
Copy link
Collaborator

@okadurin okadurin commented Sep 29, 2024

web test runner is not reliable when it comes to keyboard interaction and Playwright seems more advanced. It provides a high level API for filling out the text, interacts with the browser from the Node side as if a user typed the text. As a result the Keyboard events generated in the right order so we don't need guess how many updateComplete cycles to wait. We can consider using Playwright for testing when keyboard interaction is required.
See more details regarding the PR in the added documentation

Here are the same tests written in web test runner and with Playwright for comparison:

  • doesn't select any similar options after using delete when requireOptionMatch is false: wtr, playwright
  • allows new options when multi-choice when requireOptionMatch=false and autocomplete="both: wtr, playwright
  • hides listbox on click/enter (when multiple-choice is false): wtr, playwright

And here is the test where it detects whether the popup window flashed during the key typing: Combobox does not flash the menu when _showOverlayCondition returns "false". I checked it with the fix PR and the test passes.

Copy link

changeset-bot bot commented Sep 29, 2024

⚠️ No Changeset found

Latest commit: 4f80839

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@okadurin okadurin marked this pull request as draft September 30, 2024 07:21
@okadurin okadurin closed this Oct 1, 2024
@okadurin
Copy link
Collaborator Author

okadurin commented Oct 1, 2024

sendKeys is a wrapper around Playwright functions. So no need to bring Playwright separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant