Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calendar] Calendar buttons look the same on non-white backgrounds #2339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aghArdeshir
Copy link
Contributor

Fixes #2338

What I did

  1. Made Calendar buttons (day buttons, disabled day buttons, next/previous month/year buttons) background transparent
  2. This is because on white background they looked good, but on non-white backgrounds they started looking uglier
  3. I believe this is a better default behavior for a reusable component.
  4. However may introduce breaking changes if someone really wanted those white backgrounds on their non-white background.
  5. This is how the Calendar looks like after my changes:

Screenshot from 2024-08-21 00-27-51

(on a white background, it should keep looking as it did previously)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Calendar] Button backgrounds hard-codedly match the docs website background
1 participant