-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md: grammatical fix #2333
Conversation
|
README.md
Outdated
> Note: Our demos may look a little bland but that is on purpose. They only come with functional stylings. | ||
> This makes sense as the main use case is to extend those components and if you do you do not want to override existing stylings. | ||
> Note: Our demos may look a little bland, but that is on purpose. They only come with functional stylings. | ||
> This makes sense as the main use case is to extend those components, and if you do, you do not want to override existing stylings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two cents, please feel free to change.
> This makes sense as the main use case is to extend those components, and if you do, you do not want to override existing stylings. | |
> The lion ui components are created to be extended, and add your own styling on top of them. But you do not want to override existing stylings, so we kept ours minimal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gerjanvangeest . I tried to keep my changes as minimal as possible. But I agree to changing it totally.
To be honest, I find your suggestion also hard to understand. I ChatGPTed a bit and here are some suggestions:
"Our demo examples are intentionally plain and simple, allowing you to easily add your own designs. This approach helps you customize them to your liking without the hassle of changing or removing any existing styles."
"Our demo examples are plain on purpose, making it easy for you to customize them without removing existing styles."
"Our demos are simple so you can easily add your own style without having to change what's already there."
"Our demo examples might look simple and not very stylish. We did this on purpose. They are designed to be basic so you can easily add your own styles to them. This way, you don't have to worry about changing styles that are already there."
Its a bit hard to decide. I'll come back to this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the last one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gerjanvangeest . I applied the last suggestion, but made some last changes to it:
Note: Our demo examples might look simple and not very stylish. This is on purpose. They are designed to be basic so you can easily add your own styles to them to match your intended design, without dealing with styles that are already there.
Hope you like it 😃
I really find it hard to read this part: > This makes sense as the main use case is to extend those components and if you do you do not want to override existing stylings. Especially the part that says: "and if you do you do not want to" Even though, after these commas I inserted, it is still hard to understand. use ChatGPT's suggestion
I really find it hard to read this part:
Especially the part that says: "and if you do you do not want to"
Even though, after these commas I inserted, it is still hard to understand.