fix(input-stepper): add parseNumber and formatNumber to format the va… #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue based on locale
gerjanvangeest
requested review from
tlouisse,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
🦋 Changeset detectedLatest commit: 602f29e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryubro
approved these changes
Jul 22, 2024
| @@ -49,6 +50,50 @@ describe('<lion-input-stepper>', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Formatter', () => { | |||
| it('uses formatAmount for formatting', async () => { | |||
| expect(el.formatter).to.equal(formatNumber); | ||
| }); | ||
|
|
||
| it('formatAmount uses locale provided in formatOptions', async () => { |
| @@ -71,7 +116,7 @@ describe('<lion-input-stepper>', () => { | |||
| expect(el.value).to.equal(''); | |||
| el.dispatchEvent(new KeyboardEvent('keydown', { key: 'ArrowDown' })); | |||
| await el.updateComplete; | |||
| expect(el.value).to.equal('-1'); | |||
| expect(el.value).to.equal('−1'); | |||
There was a problem hiding this comment.
Its changing - to the official −, so "minus one" is correctly pronounced by screen readers.
okadurin
approved these changes
Jul 24, 2024
gerjanvangeest
commented
Aug 7, 2024
packages/ui/components/input-stepper/test/lion-input-stepper.test.js
Outdated
Show resolved
Hide resolved
gerjanvangeest
commented
Aug 7, 2024
packages/ui/components/input-stepper/test/lion-input-stepper.test.js
Outdated
Show resolved
Hide resolved
ayoayco
pushed a commit
to ayoayco/lion
that referenced
this pull request
Aug 21, 2024
ing-bank#2312) * fix(input-stepper): add parseNumber and formatNumber to format the value based on locale * Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js * Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js
ayoayco
pushed a commit
to ayoayco/lion
that referenced
this pull request
Aug 21, 2024
ing-bank#2312) * fix(input-stepper): add parseNumber and formatNumber to format the value based on locale * Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js * Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lue based on locale
What I did